Incorporate Interoperability Event Features to wwwverifier #371
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davidz25
reviewed
Oct 3, 2023
...d/src/main/java/com/android/identity/android/mdoc/deviceretrieval/DeviceRetrievalHelper.java
Outdated
Show resolved
Hide resolved
| mOriginInfos.add(originInfo); | ||
| } | ||
| } catch (Exception e) { | ||
| Logger.w(TAG, "OriginInfo is incorrectly formatted. We expect OriginInfo = {\"cat\": uint, \"type\": uint, \"details\": tstr} in accordance with WD6 of 18013-7."); |
There was a problem hiding this comment.
This is overly verbose. Just "OriginInfo is incorrectly formatted" also please include e in the Logger.w() call.
suzannajiwani
force-pushed
the
issue-358
branch
from
d6c78f2 to
69306a6
Compare
davidz25
reviewed
Oct 13, 2023
| mOriginInfos.add(originInfo); | ||
| } | ||
| } catch (Exception e) { | ||
| Logger.w(TAG, "OriginInfo is incorrectly formatted." + e); |
There was a problem hiding this comment.
I think it's more correct to use the Logger variant which takes an error, e.g. Logger.w(TAG, "foo", e) instead of Logger.w(TAG, "foo" + e)
Added the ability to chose between request scenarios, as well as required checks + associated logging. Also added the ability to render the returned portrait image. Manually tested.
suzannajiwani
force-pushed
the
issue-358
branch
from
69306a6 to
04132ec
Compare
davidz25
approved these changes
Oct 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added the ability to chose between request scenarios, as well as required checks + associated logging. Also added the ability to render the returned portrait image.
Manually tested.
Fixes #358